[PATCH 5/7] xf86ShowOpts.c: Remove bad code from DoShowOptions

[Alan Coopersmith]

On 11/01/11 17:50, Daniel Stone wrote:
> Hi,
>
> On 1 November 2011 22:42, Alan Coopersmith<alan.coopersmith at oracle.com>  wrote:
>> When we want to print a string, it's okay to just print it.
>> We don't need to first allocate a buffer 2 bytes bigger than the
>> string, copy the entire string unmodified to the buffer, print the
>> buffer, and then leak the buffer (though we AbortDDX 8 lines later,
>> and then just in case we survived that, call exit as well, so the
>> leak is short lived, just oh so pointless).
>>
>> Oh, and for good measure, put the "r" in String, no matter how
>> much it stings.
>
> Bonus points if you felt like just removing optionTypeToSting, now
> that it's unused.

It's still used - I just put the call directly in the ErrorF
argument, instead of storing in a variable:

+					ErrorF ("\t%s:%s\n", p->name,
+						optionTypeToString(p->type));


-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System