[PATCH] makekeys: Fix build/target word size mismatch when cross-compiling

walter harms wharms at bfs.de
Tue May 31 08:43:52 PDT 2011



Am 31.05.2011 17:24, schrieb Derek Buitenhuis:
> On 11-05-30 12:07 PM, walter harms wrote:
>> (val>>  24)&  0xff = hi
>> val&  0xff         = lo
>>
>> (maybe a simple %08x would do the same)
>>
>> Ntl. the coding style (byte oriented) indicated that the "Signature"
>> may be
>> different on big/little endian machines. i really have no idea but i
>> learned
>> to take that (and others) as warning sign.
>>
>> Obviously you took a look into this "Signature" stuff may be you have
>> an idea ...
>>
>> re,
>>   wh
> 
> As far as I can tell it should cause any trouble. Just to be sure,
> I ran makekeys, and the Keysym related functions in libX11 on
> both a big and little endian system, with identical output.
> 
> All seems to be well, unless someone else can shed some
> light on something I may have missed.
> 
> - Derek
> 

thanks for testing that.

re,
 wh


More information about the xorg-devel mailing list