[PATCH 01/14] Xext: Get rid of useless checks.

[Alan Coopersmith]

On 05/24/11 09:41 AM, Cyril Brulebois wrote:
> As noted in a comment, that can't actually happen.
> 
> Those warnings go away accordingly:
> |   CC     xvmc.lo
> | xvmc.c: In function 'XvMCExtensionInit':
> | xvmc.c:671:21: warning: the comparison will always evaluate as 'false' for the address of 'XvMCScreenKeyRec' will never be NULL [-Waddress]
> | xvmc.c: In function 'XvMCFindXvImage':
> | xvmc.c:749:22: warning: the comparison will always evaluate as 'false' for the address of 'XvMCScreenKeyRec' will never be NULL [-Waddress]
> 
> Signed-off-by: Cyril Brulebois <kibi at debian.org>
> ---
>  Xext/xvmc.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/Xext/xvmc.c b/Xext/xvmc.c
> index 4d29941..d49966f 100644
> --- a/Xext/xvmc.c
> +++ b/Xext/xvmc.c
> @@ -668,9 +668,6 @@ XvMCExtensionInit(void)
>  {
>     ExtensionEntry *extEntry;
>  
> -   if(XvMCScreenKey == NULL) /* nobody supports it */
> -	return; 

Or should that become if (!dixPrivateKeyRegistered(XvMCScreenKey)) ?

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System