[PATCH] Re: crash after setting root background pixmap to None, then setting color

[Cyril Brulebois]

Hi Jeremy,

Marko Macek <Marko.Macek at gmx.net> (21/05/2011):
> Please apply this patch:
> 
> Fix crash after resetting root window background pixmap to None, then setting background color.
> 
> Signed-off-by: Marko Macek <marko.macek at gmx.net>

it'd be nice to keep an eye on that patch and pick it for the 1.10
branch, even though it appears not to be committed to master yet.

Seems to be the same issue as in:
  http://bugs.debian.org/626331

A fix for #36986 would also be appreciated for rc3 or final:
 https://bugs.freedesktop.org/show_bug.cgi?id=36986

(still being discussed in another thread.)

> diff -ru xorg-server-1.10.1/dix/window.c xorg-server-1.10.1-new/dix/window.c
> --- xorg-server-1.10.1/dix/window.c    2011-02-25 04:27:25.000000000 +0100
> +++ xorg-server-1.10.1-new/dix/window.c    2011-05-15 15:15:03.912919996 +0200
> @@ -474,6 +474,7 @@
>          pWin->background.pixel = pScreen->whitePixel;
>          backFlag |= CWBackPixmap;
>      } else {
> +    pWin->backgroundState = BackgroundPixel;
>      if (whiteRoot)
>              pWin->background.pixel = pScreen->whitePixel;
>          else
> @@ -972,6 +973,7 @@
>      else if (party_like_its_1989)
>      MakeRootTile(pWin);
>      else {
> +    pWin->backgroundState = BackgroundPixel;
>      if (whiteRoot)
>          pWin->background.pixel = pScreen->whitePixel;
>      else
> 
> 
>     Mark

Mraw,
KiBi.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110523/8a99935c/attachment.pgp>