[PATCH xfree86] Signed-off-by: Oleh Nykyforchyn <oleh.nyk at gmail.com>

Oleh Nykyforchyn oleh.nyk at gmail.com
Mon May 23 00:23:24 PDT 2011


On Mon, 23 May 2011 12:55:20 +1000
Peter Hutterer <peter.hutterer at who-t.net> wrote:

> On Fri, May 20, 2011 at 04:30:20PM -0700, Dan Nicholson wrote:
> > We had this conversation before. I had a patch where you specified an
> > optional third argument stating what type of match you wanted. It was
> > then a trivial patch to add a regex match type. You weren't a huge
> > fan, though. :)
> > 
> > http://lists.x.org/archives/xorg-devel/2010-December/016369.html
> > 
> > I was reworking it so that it accepted programmer names like "strcmp"
> > in addition to "string", but life has gotten in the way quite a bit. I
> > still think that would be a useful addition.
> 
> right, I remember now. my main grief was that it would have been another
> rather specific syntax instead of the quite common s/foo/bar. i don't have a
> problem with regex per-se as long as we can get the syntax sorted out.
> 
BTW, if we adopt two modes: simple and regex, we don't even need an optional
argument. Consider e.g. a string of the form "|regex|". It is useless in
the simple mode, hence regex is recognized and two |-s are dropped.

Best regards. 
Oleh


More information about the xorg-devel mailing list