[PATCH] fbbltone.c: Mark bitmasks as unsigned ints

[walter harms]

Am 22.05.2011 22:50, schrieb Alan Coopersmith:
> Clears many Sun compiler warnings:
> "fbbltone.c", line 491: warning: integer overflow detected: op "<<"
> "fbbltone.c", line 491: warning: integer overflow detected: op "<<"
> "fbbltone.c", line 491: warning: integer overflow detected: op "<<"
> "fbbltone.c", line 491: warning: initializer will be sign-extended: -16777216
> "fbbltone.c", line 491: warning: integer overflow detected: op "<<"
> "fbbltone.c", line 491: warning: initializer will be sign-extended: -1
> "fbbltone.c", line 495: warning: integer overflow detected: op "<<"
> "fbbltone.c", line 495: warning: integer overflow detected: op "<<"
> "fbbltone.c", line 495: warning: integer overflow detected: op "<<"
> "fbbltone.c", line 495: warning: initializer will be sign-extended: -256
> "fbbltone.c", line 495: warning: integer overflow detected: op "<<"
> "fbbltone.c", line 495: warning: initializer will be sign-extended: -1
> "fbbltone.c", line 499: warning: integer overflow detected: op "<<"
> "fbbltone.c", line 499: warning: integer overflow detected: op "<<"
> "fbbltone.c", line 499: warning: integer overflow detected: op "<<"
> "fbbltone.c", line 499: warning: initializer will be sign-extended: -65536
> "fbbltone.c", line 499: warning: integer overflow detected: op "<<"
> "fbbltone.c", line 499: warning: initializer will be sign-extended: -1
> 
> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> ---
>  fb/fbbltone.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fb/fbbltone.c b/fb/fbbltone.c
> index 0a91575..67e7853 100644
> --- a/fb/fbbltone.c
> +++ b/fb/fbbltone.c
> @@ -428,8 +428,8 @@ fbBltOne (FbStip    *src,
>  
>  #define Mask24(x,r) (Mask24Pos(x,r) < FB_UNIT ? \
>  		     (Mask24Pos(x,r) < 0 ? \
> -		      0xffffff >> Mask24Neg (x,r) : \
> -		      0xffffff << Mask24Check(x,r)) : 0)
> +		      0xffffffU >> Mask24Neg (x,r) : \
> +		      0xffffffU << Mask24Check(x,r)) : 0)
>  
>  #define SelMask24(b,n,r)	((((b) >> n) & 1) * Mask24(n,r))
>  

The code is next to unreadable. Any change to make a function from it ?
re,
 wh