[PATCH v2 11/11] dix: replace CORE_EVENT and XI2_EVENT macros with inline functions.

[Jamey Sharp]

Looks good to me.

Reviewed-by: Jamey Sharp <jamey at minilop.net>

But perhaps this:

On Thu, May 12, 2011 at 12:35:36PM +1000, Peter Hutterer wrote:
> @@ -1952,7 +1967,7 @@ ActivateImplicitGrab(DeviceIntPtr dev, ClientPtr client, WindowPtr win,
>          grabtype = GRABTYPE_CORE;
>      else if (type == DeviceButtonPress)
>          grabtype = GRABTYPE_XI;
> -    else if (XI2_EVENT(event) && ((xGenericEvent*)event)->evtype == XI_ButtonPress)
> +    else if (xi2_get_type(event) == XI_ButtonPress)
>      {
>          type = ((xGenericEvent*)event)->evtype;
>          grabtype = GRABTYPE_XI2;

should be:

else if ((type = xi2_get_type(event)) == XI_ButtonPress)
    grabtype = GRABTYPE_XI2;

?

Jamey
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110511/32f333e3/attachment.pgp>