[PATCH 2/6] XKB: Simplify a loop in ProcXkbGetKbdByName

Cyril Brulebois kibi at debian.org
Mon May 9 09:34:09 PDT 2011


Sorry I'm late but:

Daniel Stone <daniel at fooishbar.org> (05/05/2011):
> Replace:
>     for (stuff; things; etc) {
>         if (misc || other) {
>             [...]
>         }
>     }
> with:
>     for (stuff; things; etc) {
>         if (!misc && !other)
>             continue;
>         [...]
>     }

that says nothing about that:

> -            if ((tmpd == dev) || (!IsMaster(tmpd) && GetMaster(tmpd, MASTER_KEYBOARD) == dev)) {
> +            if (tmpd != dev && GetMaster(tmpd, MASTER_KEYBOARD) != dev)

You're losing one part here; was that on purpose?

Mraw,
KiBi.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110509/a5d6f008/attachment.pgp>


More information about the xorg-devel mailing list