[Mesa-dev] [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/05/2011 01:25 PM, Jesse Barnes wrote:
> On Thu, 05 May 2011 13:17:13 -0700
> Jeremy Huddleston <jeremyhu at apple.com> wrote:
>>
>> Yes, I realize that there are some areas that use 64bit for sbc.  Do we really need 64bits for this?  If so, how do we properly to communicate the 64bit value between server/client?  Currently, your changes result in an implicit cast from 64bit to 32bits in DRI2SwapComplete which will cause problems if we really do need those extra bits:
>>
>>     if (swap_complete)
>>         swap_complete(client, swap_data, type, ust, frame, pPriv->swap_count);
>>
>> It looks to me like much more of DRI2 should be rewritten to use 32bit swap counts, or there should be some other mechanism in place to communicate the full 64bit value.
> 
> Yeah there are other mechanisms (the OML sync extension) for
> communicating the whole 64 bits.  Both the swap reply and msc reply
> deal in the full 64 bits, just the swap event (an unrelated extension)
> truncates to 32 bits.  (Also I think the 64 bit size for swap count in
> the OML extension is just inertia; getting to a count that high even at
> 120Hz is going to take awhile.)

But it could happen on, say, a desktop compositor that's been logged in
for a month.

I think the main reason is that the other two values really need to be
64-bits, so you might as well make all three be 64-bits.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk3DEsoACgkQX1gOwKyEAw/a3gCePneowulpZhTz88vmU4DRr22K
D20An35ff4MD3uuDUfJXNxE5m+wtsm1m
=bzXJ
-----END PGP SIGNATURE-----