[PULL] Accumulated small input changes

Daniel Stone daniel at fooishbar.org
Thu May 5 09:36:46 PDT 2011


On Wed, May 04, 2011 at 04:18:58PM +1000, Peter Hutterer wrote:
> On Tue, May 03, 2011 at 01:48:34AM +0100, Daniel Stone wrote:
> > On Fri, Apr 29, 2011 at 07:34:28AM -0700, Keith Packard wrote:
> > > Reviewed-by: Keith Packard <keithp at keithp.com>
> > > 
> > > I think that's all of them.
> > 
> > Ta, and yes.  Tree updated again (fa965fd..5bf3439).
> 
> please don't pull this one yet, it introduces a bug. something with grabs
> breaks.  test case is simply to open a gnome-terminal and try to select
> text, or close a window, or try click anything actually (xev that still sees
> the events for some reason). Haven't found the actual issue yet, but
> git bisect points at commit 3b9ab1dd7da48e3230f642b8e351ef76af40d1f8
>     Input: Make CheckPassiveGrabsOnWindow take InternalEvent

Yeah, rebase error: a 'return TRUE;' from CheckPassiveGrabsOnWindow
landed in CheckDeviceGrabs, with broken indentation and all.  Oops.
Have pushed these, plus the as-yet-unreviewed XKB fixes from earlier, to
daniels/for-peter.

Cheers,
Daniel


More information about the xorg-devel mailing list