[PATCH xinput 1/2] Silence compiler warning

Jeremy Huddleston jeremyhu at apple.com
Wed May 4 16:25:24 PDT 2011


Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

On May 4, 2011, at 4:14 PM, Peter Hutterer wrote:

> Static analysis claims that ptr += size may assign garbage. But since the
> protocol requires format to be 8, 16 or 32, size should always have a valid
> value. Initialize to 0 to shut up clang.
> 
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
> src/property.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/property.c b/src/property.c
> index f8b21c7..87f9fc6 100644
> --- a/src/property.c
> +++ b/src/property.c
> @@ -59,7 +59,7 @@ print_property(Display *dpy, XDevice* dev, Atom property)
>     int                 act_format;
>     unsigned long       nitems, bytes_after;
>     unsigned char       *data, *ptr;
> -    int                 j, done = False, size;
> +    int                 j, done = False, size = 0;
> 
>     name = XGetAtomName(dpy, property);
>     printf("\t%s (%ld):\t", name, property);
> -- 
> 1.7.4.4
> 



More information about the xorg-devel mailing list