[PATCH libXi] Allocate enough memory for raw events + extra data.

Jeremy Huddleston jeremyhu at apple.com
Tue May 3 09:35:44 PDT 2011


Ok, then I'll just 
On May 3, 2011, at 8:59 AM, Alan Coopersmith wrote:

> On 05/ 2/11 11:00 PM, Jeremy Huddleston wrote:
>>> http://people.freedesktop.org/~jeremyhu/analyzer/yuffie/20110429-1617/libXi/report-yDDyYj.html#EndPath
>>> "undefined allocation of 0 bytes" would be a server bug afaict
>> 
>> I dunno... is there anywhere that we guarantee that Xmalloc(0) returns NULL?  If so, then the macro should probably be ((size) > 0 ? malloc(size) : NULL) ... hopefully there is nothing actually using side-effects inside of Xmalloc(...) ...
> 
> We guarantee Xmalloc(0) returns non-NULL - from <X11/Xlibint.h>:

Ok, addressed in Xlib.  That should clear up a number of false positives.




More information about the xorg-devel mailing list