[PATCH] [RFC] dix/mi: remove ChangeWindowAttributes from rendering path.

Dave Airlie airlied at gmail.com
Thu Mar 31 16:52:25 PDT 2011

On Thu, Mar 31, 2011 at 7:34 PM, Mark Kettenis <mark.kettenis at xs4all.nl> wrote:
>> From: Dave Airlie <airlied at gmail.com>
>> Date: Thu, 31 Mar 2011 16:07:46 +1000
>> From: Dave Airlie <airlied at redhat.com>
>> This moves ChangeWindowAttributes to mi, and calls a new hook
>> that fb/exa can use to fixup the pixmap properly.
>> I've looked at XAA and it seems this should work there as well,
>> and I'm sure UXA is like EXA.
> Hmm.  The version of the xf86-video-intel driver we use on OpenBSD
> calls fbChangeWindowAttributes().  We're stuck with that particular
> version for now since newer versions have the modesetting code ripped
> out.  I suppose a simple s/fbChangeWindowAttributes/miChangeWindowAttributes/
> would be enough to make the driver compile (and work) again.  But
> probably we'll have forgotten about that in a couple of months when we
> import the new xserver code with this change.  Any reason not to add a
> #define fbChangeWindowAttributes miChangeWindowAttributes
> to fb.h for API compatibility?

Because I'd like to remove all Window stuff from fb layer, adding compat hooks
might be okay for one release but at some point you'll have to face
them, and the
earlier the better IMHO.


More information about the xorg-devel mailing list