[PATCH] fb: drop fbCopyWindowProc its the same as fbCopyNtoN

Soeren Sandmann sandmann at cs.au.dk
Thu Mar 31 06:46:20 PDT 2011

Dave Airlie <airlied at gmail.com> writes:

> From: Dave Airlie <airlied at redhat.com>
> From what I can see these functions act the exact same way,
> that is unless I'm missing something subtle.

As far as I can tell, the difference is that fbCopyWindowProc() always
uses GX_COPY and FB_ALLONES, whereas fbCopyNtoN() gets those from the
GC. However, since if pGC in fbCopyNtoN() is NULL, it uses GX_COPY and
FB_ALLONES, and pGC is NULL in calls to fbCopyWindowProc(), it should be
fine to just use fbCopyNtoN().

Reviewed-by: Soren Sandmann <ssp at redhat.com>


More information about the xorg-devel mailing list