[PATCH] fb: cleanup fbChangeWindowAttributes

Mark Kettenis mark.kettenis at xs4all.nl
Wed Mar 30 23:59:30 PDT 2011


> From: Dave Airlie <airlied at gmail.com>
> Date: Thu, 31 Mar 2011 15:35:42 +1000
> 
> From: Dave Airlie <airlied at redhat.com>
> 
> This cleans up the duplication in fbChangeWindowAttributes,
> and fixes a bug if the fb24_32ReformatTile ever failed,
> since the old code would happily dereference it in the fbEvenTile
> call a few lines later.
> 
> Signed-off-by: Dave Airlie <airlied at redhat.com>

Makes sense to me.

Reviewed-by: Mark Kettenis <kettenis at openbsd.org>

> ---
>  fb/fbwindow.c |   55 ++++++++++++++++++++-----------------------------------
>  1 files changed, 20 insertions(+), 35 deletions(-)


More information about the xorg-devel mailing list