[PATCH 1/2] fb: drop defines that aren't used/necessary anymore.

Dave Airlie airlied at gmail.com
Wed Mar 30 20:26:11 PDT 2011


On Thu, Mar 31, 2011 at 5:04 AM, Mark Kettenis <mark.kettenis at xs4all.nl> wrote:
>> From: Keith Packard <keithp at keithp.com>
>> Date: Wed, 30 Mar 2011 10:55:04 -0700
>>
>> On Tue, 29 Mar 2011 09:55:56 +0200 (CEST), Mark Kettenis <mark.kettenis at xs4=
>> all.nl> wrote:
>>
>> > Unfortunately this sort of automatically generated diffs have some
>> > drawbacks...
>>
>> Yeah, we should probably have a follow-on manual patch that cleans up
>> the results of the automatic one. Otherwise, we'll just leave a nice
>> trail of confusion in the code.
>
> It'd make some sense to make that part of the same commit though, just
> in case someone wants to revert the change at some point in the future.

I can work with that, so I've pushed a branch to my repo,

The following changes since commit e0a2ad51dfb7373aa602335490d9666d6101b5ea:

  Merge remote-tracking branch 'ajax/xserver-next' (2011-03-30 10:51:27 -0700)

are available in the git repository at:

  ssh://people.freedesktop.org/~airlied/xserver/ fb-define-cleanup-squashed

Dave Airlie (1):
      Squashed commit of the following:

 fb/fb.h        |   34 ++--------------------------------
 fb/fballpriv.c |    4 ----
 fb/fbarc.c     |    4 ----
 fb/fbbits.c    |    2 --
 fb/fbblt.c     |    8 --------
 fb/fbbltone.c  |   22 ----------------------
 fb/fbcopy.c    |    2 --
 fb/fbgc.c      |    2 --
 fb/fbgetsp.c   |    2 --
 fb/fbglyph.c   |   18 ------------------
 fb/fbimage.c   |    4 ----
 fb/fbline.c    |    8 --------
 fb/fboverlay.c |    8 --------
 fb/fbpixmap.c  |    2 --
 fb/fbpoint.c   |    6 ------
 fb/fbscreen.c  |    6 ------
 fb/fbseg.c     |   14 --------------
 fb/fbsetsp.c   |    2 --
 fb/fbsolid.c   |    4 ----
 fb/fbstipple.c |    4 ----
 fb/fbwindow.c  |    6 ------
 21 files changed, 2 insertions(+), 160 deletions(-)

This contains a squashed commit of the auto generator + addback compat
defines + comment removal patch.

Keith you can pull if it it makes you happy.

Dave.


More information about the xorg-devel mailing list