[PATCH] damage: Remove the 'damage window' resource type

Christopher James Halse Rogers christopher.halse.rogers at canonical.com
Wed Mar 30 18:24:49 PDT 2011


On Wed, 2011-03-30 at 15:35 +0200, Soeren Sandmann wrote:
> Adam Jackson <ajax at redhat.com> writes:
> 
> > This may be more correct in that it cleans up the Damage.  I think it's
> > less correct in that you break existing clients.  FreeDamageExtWin()
> > deletes the Damage XID, but the spec mentions nothing about magically
> > garbage-collecting Damages just because their drawable went away.  From
> > a quick check, it looks like mutter pushes an error handler around
> > XDamageDestroy(), but compiz and kwin do not.
> 
> I think window managers have traditionally just handled all errors at
> all times, but that metacity was written to be more precise about it.
> 
> It may be that kwin and compiz are already handling these errors even if
> they don't handle them explicitly.
> 

When I was looking at compiz 0.9 recently I was somewhat surprised to
find that it eats *all* X errors silently.  It wouldn't surprise me to
find that earlier versions, and kwin, do likewise.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110331/46d42479/attachment.pgp>


More information about the xorg-devel mailing list