[PATCH] mi: Remove unused overlay support

Dave Airlie airlied at gmail.com
Tue Mar 29 13:30:54 PDT 2011

On Wed, Mar 30, 2011 at 3:40 AM, Aaron Plattner <aplattner at nvidia.com> wrote:
> On Tue, Mar 29, 2011 at 09:47:19AM -0700, Mikhail Gusarov wrote:
>> Twas brillig at 09:26:19 29.03.2011 UTC-07 when aplattner at nvidia.com did gyre and gimble:
>>  AP> NAK.  This code is not NVIDIA-specific just because only the NVIDIA
>>  AP> driver currently uses it.
>> I did not claim it. I just said it's unused.
> And I'm disagreeing about it being unused.  I'm actually surprised that
> none of the other drivers use it since workstation overlays are still
> heavily used.
>>  AP> We can move it into the driver if you really think it's necessary,
>>  AP> but from a software design standpoint it's the wrong thing to do.
>> Keeping unused code in mi is wrong from software engineering standpoint
>> as well.
> I disagree.  mi is a toolkit of machine-independent driver support
> routines.  While I understand that X needs to advance forward and gain
> features, I don't think it should turn its back on its loyal professional
> workstation heritage either.  NVIDIA is committed to supporting both the
> forward advancement of the window system and traditional X features like
> overlays.  It is disappointing if no other driver shares both those
> commitments.
> The mi overlay code is not hardware-specific, and architecturally makes the
> most sense in the X server's mi layer.  You can sign me up as the
> maintainer if you think it's a maintenance burden.

It isn't now but its about to be, I hope you have lots of time because
I'm going to have
to break it horribly and I've no hardware to test what it ends up doing on.

I personally think any code in the X server that isn't exercised by an
open source driver should be removed ASAP,
If this means you guys adding code to nv or nouveau to justify its
existance then so be it as long as we have a
useful test case.


> -- Aaron
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel

More information about the xorg-devel mailing list