[PATCH] damage: Remove the 'damage window' resource type

Adam Jackson ajax at redhat.com
Tue Mar 29 11:40:54 PDT 2011


On Tue, 2011-03-29 at 08:02 -0700, Keith Packard wrote:
> On Tue, 29 Mar 2011 10:44:54 -0400, Adam Jackson <ajax at redhat.com> wrote:
> 
> > Given that, I think we have to make it so damage actions against a
> > Damage that has lost its Drawable simply fizzle, and continue to leave
> > cleanup to the clients.  Compiled, not tested:
> 
> Yeah, that sounds right to me. Retains the current semantics, but
> removes the pointer to freed memory.

Hmph.  In trying to build a testcase for this I think I've discovered
that we _do_ already gc Damages when their drawables die; it's just
harder to see because it's done as a callback from miext/damage's
wrappers around Destroy{Pixmap,Window}.

Which, I suspect, means my original patch was simply correct.  But I'll
keep digging.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110329/e4e75e36/attachment.pgp>


More information about the xorg-devel mailing list