[PATCH] mi: Remove unused overlay support

Mikhail Gusarov dottedmag at dottedmag.net
Tue Mar 29 09:47:19 PDT 2011


Twas brillig at 09:26:19 29.03.2011 UTC-07 when aplattner at nvidia.com did gyre and gimble:

 AP> NAK.  This code is not NVIDIA-specific just because only the NVIDIA
 AP> driver currently uses it.

I did not claim it. I just said it's unused.

 AP> We can move it into the driver if you really think it's necessary,
 AP> but from a software design standpoint it's the wrong thing to do.

Keeping unused code in mi is wrong from software engineering standpoint
as well.

Quoting IRC:

<keithp> airlied: I thought mga was using mioverlay
<airlied> keithp: no I think its been gutted
<keithp> sweet!
<keithp> sounds like it's time to nuke it then
<airlied> the old patch in-tree still works
<airlied> dottedmag: feel like resubmitting it?

 AP> It's ironic that I'm the one arguing to keep our driver less
 AP> proprietary.

Why not bundle mioverlay.c beside the driver with MIT license attached
then? It makes no differene if some driver would ever start use it by
pulling back in server, but it won't clutter mi until then.

-- 
  http://fossarchy.blogspot.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110329/f737ee67/attachment.pgp>


More information about the xorg-devel mailing list