[PATCH] fb: drop FB_SCREEN_PRIVATE and FB_24BIT and FB_24_32BIT ifdefs

Keith Packard keithp at keithp.com
Mon Mar 28 21:09:26 PDT 2011

On Tue, 29 Mar 2011 13:34:07 +1000, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
> These don't appear to ever be not wanted in the current server code,
> this drops them all, it leaves FB_24_32BIT defines for the Intel
> driver UXA code which seems to use the define.

Was this diff generated with some automatic tool? If so, can you provide
the command line you used? I'd love to have some confidence that you
didn't miss anything by accident...

Otherwise, yes, this seems like a good plan. Many of these
'options' were put in the fb code to allow a minimal X server to be
built with as little depth-specific code as possible, but in the
loadable-driver world, we really can't do that.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110328/b47c9fc5/attachment.pgp>

More information about the xorg-devel mailing list