[PATCH] Track damage for fbTrapezoids() and fbTriangles().

Soeren Sandmann sandmann at cs.au.dk
Mon Mar 28 09:40:42 PDT 2011


Michel Dänzer <michel at daenzer.net> writes:

> On Mon, 2011-03-28 at 11:47 -0400, Søren Sandmann wrote: 
>> From: Søren Sandmann Pedersen <ssp at redhat.com>
>> 
>> These calls no longer go through the miComposite(),
>
> I can't seem to find any reference to miComposite() in the Git history.
> Do you mean miTriangles()?

I meant CompositePicture() actually (which then calls
screen->Composite()). This is the only composite call that is wrapped by
damage.

>> so damage was no longer generated for them. This patch simply damages
>> the entire destination clip region.
>
> [...]
>
>> @@ -117,6 +118,8 @@ fbShapes (CompositeShapesFunc	composite,
>>      {
>>  	pixman_format_code_t format;
>>  
>> +	DamageRegionAppend (pDst->pDrawable, pDst->pCompositeClip);
>> +
>>  	if (!maskFormat)
>>  	{
>>  	    int i;
>
> Don't you also need to call DamageRegionProcessPending() after the
> operation?

Yes, I think I do, thanks. New version below.

Soren.




More information about the xorg-devel mailing list