[PATCH] Xi: take XI2 requests into account also for the swapping case.
peter.hutterer at who-t.net
Sun Mar 27 22:22:21 PDT 2011
On Sun, Mar 27, 2011 at 10:20:28PM +0200, Julien Cristau wrote:
> On Sun, Mar 27, 2011 at 21:32:10 +0200, Matthieu Herrb wrote:
> > On Sun, Mar 27, 2011 at 09:06:08PM +0200, Julien Cristau wrote:
> > > This seems dangerous if you're, say, building an X server that only
> > > supports XI 2.0 against the XI 2.1 headers. Should probably be
> > > "if (stuff->data >= ARRAY_SIZE(SProcIVector)) ..."
> > > (looks like there's no ARRAY_SIZE macro outside of glx, but you get the
> > > idea)
> > >
> > Well it matches the test done for the non-swapping case just 10 lines
> > above:
> I know. It just means they're both wrong, IMO.
yes, they both need to be fixed.
More information about the xorg-devel