[PATCH] fix overquoting of $(XKBCONFIGROOT)

Matt Turner mattst88 at gmail.com
Thu Mar 24 08:59:10 PDT 2011

On Thu, Mar 24, 2011 at 1:20 PM, Gaetan Nadon <memsize at videotron.ca> wrote:
> This is what I get on Ubuntu before the patch:
>     -DDFLT_XKB_CONFIG_ROOT=\"/home/nadon/xorg/src/share/X11/xkb\"
> Is this a platform difference?

I kind of think so.

> With the patch I get:
> -DDFLT_XKB_CONFIG_ROOT='/home/nadon/xorg/src/share/X11/xkb'
> but I also get:
> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../../src
> -I../../include -I../../src -I/home/nadon/xorg/src/include -Wall
> -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes
> -Wmissing-declarations -Wnested-externs -fno-strict-aliasing
> -Wbad-function-cast -Wformat=2 -Wold-style-definition
> -Wdeclaration-after-statement
> -DDFLT_XKB_CONFIG_ROOT=/home/nadon/xorg/src/share/X11/xkb -g -O2
> -fvisibility=hidden -MT listing.lo -MD -MP -MF .deps/listing.Tpo -c
> listing.c  -fPIC -DPIC -o .libs/listing.o
> listing.c: In function ‘xkb_list_components’:
> listing.c:494: error: expected expression before ‘/’ token
> listing.c:494: error: too few arguments to function ‘GenerateComponent’
> What are your results before/after the patch?

Before: http://bugs.gentoo.org/attachment.cgi?id=267041
After: the compile succeeds, using -DDFLT_XKB_CONFIG_ROOT=\"/usr/share/X11/xkb\"

It looks like xkeyboard-config's .pc file has quotes on my system, and
not yours or Dan's systems, for some reason.


More information about the xorg-devel mailing list