[PATCH xserver] GLX: Support TLS with better portability

Jeremy Huddleston jeremyhu at apple.com
Wed Mar 23 08:54:51 PDT 2011

On Mar 22, 2011, at 9:13 PM, tom fogal wrote:

> Jeremy Huddleston <jeremyhu at apple.com> writes:
>> AX_TLS detects when toolchains support __thread or
>> __declspec(thread), but existing code assumed __thread.
> Good find.
>> configure.ac            |    1 +
> [snip]
>> +	AC_DEFINE(__XSERVER_TLS, ${ac_cv_tls}, [Thread local storage directive]
> The AX_TLS macro should AC_DEFINE_UNQUOTED "TLS".  I recommend using
> that instead of inventing our own define.

Ah, you're right.  It does.

> I haven't looked to see if we have __thread anywhere else that should
> go away in favor of the macro, but I assume you have.

I grepped through xserver because it was what broke in tinderbox.  I did not check mesa (which I think got a similar patch) because mesa does not currently build on darwin.

More information about the xorg-devel mailing list