Please revert Re: [PATCH 1/4] dix: Remove usage_class from pixmaps, store it in ->drawable.class

Adam Jackson ajax at nwnk.net
Fri Mar 18 11:56:45 PDT 2011


On 3/18/11 12:35 AM, Dave Airlie wrote:
> Hi Keith,
>
> Please revert 1564c82417d201de5b9a5ec5e7aa4ef14c45fbad (commit for this patch).
>
> The drivers used the top bits of the usage_hint to store driver
> private flags (intel, radeon, nouveau).
>
> With EXA we need to get at this data so if we migrate the pixmap we
> can create the correct type of pixmap in the driver, however this
> commit truncates the usage_hint into 8-bit class and loses all the
> good stuff.

Weak.  I feel like there should be some cleaner way to do that.

- ajax


More information about the xorg-devel mailing list