Please revert Re: [PATCH 1/4] dix: Remove usage_class from pixmaps, store it in ->drawable.class

[Dave Airlie]

Hi Keith,

Please revert 1564c82417d201de5b9a5ec5e7aa4ef14c45fbad (commit for this patch).

The drivers used the top bits of the usage_hint to store driver
private flags (intel, radeon, nouveau).

With EXA we need to get at this data so if we migrate the pixmap we
can create the correct type of pixmap in the driver, however this
commit truncates the usage_hint into 8-bit class and loses all the
good stuff.

Dave.


On Tue, Mar 8, 2011 at 8:25 AM, Soeren Sandmann <sandmann at cs.au.dk> wrote:
> Adam Jackson <ajax at redhat.com> writes:
>
>> The class field was unused for pixmaps, and we don't have enough classes
>> to justify a whole uint32 anyway.
>>
>> Signed-off-by: Adam Jackson <ajax at redhat.com>
>
> You mean usage_hint in the subject line, but other than that,
>
> Reviewed-by: Soren Sandmann <ssp at redhat.com>
>
>
>
> Soren
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>