libX11: Changes to 'master'

Jeremy Huddleston jeremyhu at
Thu Mar 17 16:09:21 PDT 2011

There's been quite a bit of code churn in libX11, and I want to get Jamey's fixes out.  If nobody yells at me not to in the next half hour or so, I'm going to tag/push an updated libX11 tag (1.4.2).

Thanks for those changes Jamey.


On Mar 15, 2011, at 16:57, Jamey Sharp wrote:

> src/XlibInt.c |   14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
> New commits:
> commit 83e1ba59c48c79f8b0a7e7aa0b9c9cfd84fa403d
> Author: Jamey Sharp <jamey at>
> Date:   Tue Mar 15 16:48:07 2011 -0700
>    Call _XErrorFunction without holding the Display lock.
>    Historically, Xlib dropped the Display lock around the upcall to any
>    user-supplied _XErrorFunction, but somewhere along the way I quit doing
>    that if you built with XCB. The reasons are lost somewhere in the
>    pre-git history of Xlib/XCB, and I can't now see any reason to hold the
>    lock.
>    The documentation for XSetErrorHandler still applies though:
>        Because this condition is not assumed to be fatal, it is acceptable
>        for your error handler to return; the returned value is ignored.
>        However, the error handler should not call any functions (directly
>        or indirectly) on the display that will generate protocol requests
>        or that will look for input events.
>    So while you are now once again permitted to re-enter Xlib from the
>    error handler, you're only allowed to call non-protocol functions.
>    Signed-off-by: Jamey Sharp <jamey at>
> _______________________________________________
> xorg-commit mailing list
> xorg-commit at

More information about the xorg-devel mailing list