[PATCH 3/4] xfree86: warning fix

Dan Nicholson dbn.lists at gmail.com
Tue Mar 15 13:45:16 PDT 2011


On Tue, Mar 15, 2011 at 8:37 AM, Keith Packard <keithp at keithp.com> wrote:
> On Tue, 15 Mar 2011 11:05:06 -0400, Adam Jackson <ajax at redhat.com> wrote:
>
>> -                             if (asprintf(&s, "%ul %ul", val1, val.num) == -1)
>> +                             if (asprintf(&s, "%lu %u", val1, val.num) == -1)
>
> Reviewed-by: Keith Packard <keithp at keithp.com>
>
> (as an aside, I was amused to find that 'val' is a global symbol in the
> X server).

Well played. The xorg.conf parser holds some real gems.

--
Dan


More information about the xorg-devel mailing list