[PATCH 1/4] dix: warning fix

Keith Packard keithp at keithp.com
Tue Mar 15 08:35:12 PDT 2011

On Tue, 15 Mar 2011 11:05:04 -0400, Adam Jackson <ajax at redhat.com> wrote:

> -	ErrorF("[dix] AddResource(%lx, %lx, %lx), client=%d \n",
> -		(unsigned long)id, type, (unsigned long)value, client);
> +	ErrorF("[dix] AddResource(%x, %x, %lx), client=%d \n",
> +	       id, type, (unsigned long)value, client);

I hate printf. This does assume that XID is the same as 'unsigned int'
on all machines. I think XID is still 'unsigned long' on 32-bit
machines, right? We could use %lx and a cast to unsigned long

Unless someone else has a concern that 'XID is not the same size as
'int', we should probably just use %x and eliminate the ugly cast.

Reviewed-by: Keith Packard <keithp at keithp.com>

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110315/7d897ac4/attachment.pgp>

More information about the xorg-devel mailing list