[PATCH v2:libXt] Add test framework similar to xserver and use it to test XtAsprintf

Daniel Stone daniel at fooishbar.org
Thu Mar 10 06:37:04 PST 2011

On Thu, Mar 10, 2011 at 09:34:39AM -0500, Gaetan Nadon wrote:
> On Thu, 2011-03-10 at 10:47 +0100, Julien Cristau wrote:
> > > I think this won't work for gnu/kfreebsd.  Maybe use *-gnu for the
> > glibc
> > > case, and put it before the *bsd* one?
> > > 
> > Make that *-gnu* so it can handle linux-gnueabi (used on arm)...
> All the ones for linux I have see used in xorg are *linux*.  That should
> cover arm as well.
> I am not sure combining kfreebsd with arm will help the less informed
> reader and may
> cause the injection of a bug.
> Generally speaking, it's almost impossible to figure out what a * may
> expand to,
> so the more explicit we can be, the lower the risk of errors.

Shrug, the point is that you want to test for glibc, not the Linux
kernel, as _MALLOC_PERTURB is a glibc feature.  So testing for *-gnu* is
a more clearer way to catch it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110310/2f2e68f8/attachment.pgp>

More information about the xorg-devel mailing list