[PATCH] Xi: fix XI2 passive grab reply length calculation

Peter Hutterer peter.hutterer at who-t.net
Tue Mar 8 14:38:32 PST 2011


On Tue, Mar 08, 2011 at 01:37:13PM +0000, Daniel Stone wrote:
> On Tue, Mar 08, 2011 at 02:44:02PM +1000, Peter Hutterer wrote:
> > If modifiers failed, the reply length was 4 bytes too short.
> > 
> > Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> 
> This only works because xXIGrabModifierInfo is a multiple of 32, else
> rounding would ruin your day, but:

it's a protocol struct, they are all multiples of 32 anyway. only exception
here are the keycodes with 16 bit IIRC.

> Reviewed-by: Daniel Stone <daniel at fooishbar.org>

thanks

Cheers,
  Peter


More information about the xorg-devel mailing list