[PATCH 1/2] os: Fix buggy integer comparison.

Cyril Brulebois kibi at debian.org
Mon Mar 7 05:32:20 PST 2011

Keith Packard <keithp at keithp.com> (06/03/2011):
> […]
> We want the former result, not the latter.

Unless being pointed to the appropriate stuff from 2002 by Alan
(thanks!), what we want isn't exactly clear while going through the
code. Might deserve some comments, maybe?

That was already reported nearly a year ago by the way:

You suggested in

to remove the buggy assert, while I suggested that:
| [If that's a supposedly-supported codepath, the assert should probably become:
| assert((pAuth->timer == NULL) || …);
| but I don't think that should happen at all.
| ]
in my bug report:

Shall we proceed with tweaking that assert()? A quick testing shows
that both my 1.7 and 1.10 servers stop going down with a trivial xauth

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110307/0ae0d10e/attachment.pgp>

More information about the xorg-devel mailing list