[PATCH v2] dri2: Initialize padding in DRI2GetBuffers reply

oliver.mcfadden at nokia.com oliver.mcfadden at nokia.com
Fri Mar 4 10:21:45 PST 2011


Hi,

Sorry about top-posting, currently on my N900 on a airplane.

Pauli, it would have been nice to include:
Reported-by: Oliver McFadden <...
but if it has already been merged, no worries, you did write the patch after all. :-)

-- Oliver, N900.

----- Original message -----
> On Wed, Mar 02, 2011 at 04:08:23PM +0200, Pauli wrote:
> > From: Pauli Nieminen <ext-pauli.nieminen at nokia.com>
> > 
> > This fixes following valgrind reported error about padding being
> uninitialised.
> > 
> > ==9999== Syscall param writev(vector[...]) points to uninitialised
> byte(s)
> > ==9999==       at 0x4AB7054: writev (writev.c:51)
> > ==9999==       by 0x5E237: _XSERVTransWritev (Xtrans.c:912)
> > ==9999==       by 0x6154B: FlushClient (io.c:937)
> > ==9999==       by 0x61CDF: WriteToClient (io.c:859)
> > ==9999==       by 0x4938B: WriteEventsToClient (events.c:5702)
> > ==9999==       by 0x4BF43: TryClientEvents (events.c:1953)
> > ==9999==       by 0x4F983: DeliverGrabbedEvent (events.c:3857)
> > ==9999==       by 0xEA527: ProcessOtherEvent (exevents.c:1102)
> > ==9999==       by 0x115313: ProcessPointerEvent (xkbAccessX.c:729)
> > ==9999==       by 0xB16BF: mieqProcessDeviceEvent (mieq.c:423)
> > ==9999==       by 0xB174B: mieqProcessInputEvents (mieq.c:481)
> > ==9999==       by 0x653B3: ProcessInputEvents (xf86Events.c:165)
> > ==9999==   Uninitialised value was created by a stack allocation
> > ==9999==       at 0x503FAA0: send_buffers_reply (dri2ext.c:210)
> > 
> > Signed-off-by: Pauli Nieminen <ext-pauli.nieminen at nokia.com>
> 
> Reviewed-by: Daniel Stone <daniel at fooishbar.org>
> 
<Attachment>   Digital signature.asc
<Attachment>   ATT00001.txt


More information about the xorg-devel mailing list