[PULL] Server build fixes

Dan Nicholson dbn.lists at gmail.com
Thu Mar 3 20:42:55 PST 2011

On Thu, Mar 3, 2011 at 2:10 PM, Keith Packard <keithp at keithp.com> wrote:
> On Sat, 26 Feb 2011 11:01:38 -0800, Dan Nicholson <dbn.lists at gmail.com> wrote:
>> It should get run every time config.status is run, which is every time
>> configure runs. So, sdksyms.dep should get updated exactly when the
>> Makefiles do. I do agree that sdksyms.c shouldn't be shipped in the
>> tarball, but I think it should work anyway (patch attached).
> Do you have a 'final' patch that you'd like me to merge at this point?

I think your original patch is the right way to go. sdksyms.dep _is_
needed as far as I can tell because we need sdksyms.c to depend on all
the headers. Say you add a new symbol in dix.h. That won't necessarily
mean that the *config.h files get rebuilt. However adding an explicit
dependency on *config.h means that you will definitely get sdksyms.c
regenerated after you run configure. That seems like a safe thing to
do. You can include my:

Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>

More information about the xorg-devel mailing list