[PATCH 09/11] glx: Lobotomize _glapi_get_proc_address

Julien Cristau jcristau at debian.org
Thu Mar 3 13:06:52 PST 2011


On Thu, Mar  3, 2011 at 14:07:23 -0500, Adam Jackson wrote:

> This isn't a meaningful thing in the indirect glx loader, so just warn
> if it ever happens and move on.
> 
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  glx/glapi.c |   39 ++++++---------------------------------
>  1 files changed, 6 insertions(+), 33 deletions(-)
> 
> diff --git a/glx/glapi.c b/glx/glapi.c
> index a706438..de5e7ea 100644
> --- a/glx/glapi.c
> +++ b/glx/glapi.c
> @@ -54,6 +54,7 @@
>  
>  #include <dix-config.h>
>  #include <X11/Xfuncproto.h>
> +#include <os.h>
>  #define PUBLIC _X_EXPORT
>  
>  #else
> @@ -713,43 +714,15 @@ _glapi_add_dispatch( const char * const * function_names,
>     return offset;
>  }
>  
> -/**
> - * Return pointer to the named function.  If the function name isn't found
> - * in the name of static functions, try generating a new API entrypoint on
> - * the fly with assembly language.
> +/*
> + * glXGetProcAddress doesn't exist in the protocol, the drivers never call
> + * this themselves, and neither does the server.  warn if it happens though.
>   */
>  _glapi_proc
>  _glapi_get_proc_address(const char *funcName)
>  {

the function isn't _X_EXPORT, so it's not even possible to call it,
right?

Cheers,
Julien


More information about the xorg-devel mailing list