[PATCH libXi] Add XI2 library-internal array offsets to XIint.h

Peter Hutterer peter.hutterer at who-t.net
Wed Mar 2 15:37:51 PST 2011

On Wed, Mar 02, 2011 at 11:36:43AM +0000, Daniel Stone wrote:
> On Tue, Sep 07, 2010 at 03:33:31PM +1000, Peter Hutterer wrote:
> > These defines are currently defined in XI.h and XI2.h. Their only use is as
> > offset into a library-internal array. Move them to XIint.h so they may be
> > removed from the protocol headers with the next revision.
> NAK: while you're right, these have always been in the protocol and we
> might break clients using them in a fairly dumb manner by moving them.
> I think we should just place future ones in libXi, acknowledge that XI.h
> is a wasteland anyway, and leave XInput_2_0 in XI2.h as a reminder not
> to make the same mistake again.

I agree that we can't easily remove them from the protocol headers.
I think it's still useful adding this patch though if only for consistency
and readability (it's ifdef-guarded anyway).


More information about the xorg-devel mailing list