[PATCH v2 03/28] Input: Add flags to RawDeviceEvent

Daniel Stone daniel at fooishbar.org
Fri Jun 24 04:14:26 PDT 2011


Hi,

On Fri, Jun 24, 2011 at 09:51:38AM +1000, Peter Hutterer wrote:
> On Thu, Jun 23, 2011 at 10:53:34AM +0100, Daniel Stone wrote:
> > Hmm, it's hard to say.  Certainly on the face of it it seems cleaner to
> > leave it as driver-native data, but I'm kind of worried that clients may
> > have come to rely on the principle that any DeviceEvent will show up
> > with a corresponding RawEvent.

Now I think about this, I'm almost certain it won't be a problem, given
that RawButtonRelease events didn't exist until XI 2.1 either. :)

> > If we're going down this route, it might be best to cut raw events from
> > things like XTEST/WarpPointer as well?
> 
> WarpPointer certainly. XTEST not sure, because in the end the XTest device
> is a device, so the data could be regarded as raw data.
> 
> Plus, xtest is currently the only sensible way to emulate devices from an X
> client, being able to use raw events here seems beneficial (and it doesn't
> require extra code anyway).

OK, seems fair.

Cheers,
Daniel


More information about the xorg-devel mailing list