[PATCH v2 28/28] Input: Add smooth-scrolling support to GetPointerEvents

Daniel Stone daniel at fooishbar.org
Thu Jun 23 02:52:16 PDT 2011


On Thu, Jun 23, 2011 at 01:35:59PM +1000, Peter Hutterer wrote:
> every time I see 95 lines being added to one function something in me diese
> a little.
> you don't seem to be accessing anything but v_scroll_axis and h_scroll_axis
> from the local stack anyway, why not make the while loop a:
>     int emulate_scroll_button_events(events, device, hscroll, vscroll)

Ha, sure.

> Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net> for the lot though
> (well, the unreviewed ones)

Thanks.  Do you want everything but smooth-scrolling in my for-peter
branch, or pend for later, or?

Cheers,
Daniel


More information about the xorg-devel mailing list