[PATCH util-macros] XORG_WITH_XSLTPROC: warn at development time rather than config time

[Dan Nicholson]

On Wed, Jun 22, 2011 at 9:47 AM, Gaetan Nadon <memsize at videotron.ca> wrote:
> Catching up unimplemented features should be done earlier by the developer
> during autoconf rather than during configure.
>
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> ---
>  xorg-macros.m4.in |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in
> index e8c14c3..0527dfe 100644
> --- a/xorg-macros.m4.in
> +++ b/xorg-macros.m4.in
> @@ -457,6 +457,8 @@ AM_CONDITIONAL([HAVE_XMLTO], [test "$have_xmlto" = yes])
>  #
>  AC_DEFUN([XORG_WITH_XSLTPROC],[
>  AC_ARG_VAR([XSLTPROC], [Path to xsltproc command])
> +# Preserves the interface, should it be implemented later
> +m4_ifval([$1], [m4_warn([syntax], [Checking for xsltproc MIN-VERSION is not implemented])])
>  m4_define([_defopt], m4_default([$2], [auto]))
>  AC_ARG_WITH(xsltproc,
>        AS_HELP_STRING([--with-xsltproc],
> @@ -487,10 +489,6 @@ else
>    AC_MSG_ERROR([--with-xsltproc expects 'yes' or 'no'])
>  fi
>
> -# Checking for minimum version is not implemented
> -# but we want to keep the interface consistent with other commands
> -m4_ifval([$1],[AC_MSG_WARN(Checking for MIN-VERSION is not implemented.)])
> -
>  AM_CONDITIONAL([HAVE_XSLTPROC], [test "$have_xsltproc" = yes])
>  ]) # XORG_WITH_XSLTPROC

Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>