[PATCH util-macros] XORG_WITH_FOP: add minimum version checking support

Dan Nicholson dbn.lists at gmail.com
Wed Jun 22 10:45:14 PDT 2011


On Wed, Jun 22, 2011 at 6:41 AM, Gaetan Nadon <memsize at videotron.ca> wrote:
> Adding this feature is motivated by a bug in fop 0.95 where
> fop crashes in the presence of some characters like the latin capital
> sharp s. Fop version 1.0 works correctly.
>
> This is the same feature found in XMLTO and the likes.
> In the macro public interface there is a shift in parameter position
> for the DEFAULT parameter. Doing development on older libraries
> (point releases on older versions) will still work the same way as
> the "no" value will be interpreted as the minimum version. It won't
> be found, so fop will be disabled anyway.
>
> Only libX11 has used XORG_WITH_FOP(no) and will be changed with a version
> bump on util-macros.
>
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>

It's unfortunate that doing this in a backwards compatible way would
break the argument order convention. It's too bad those didn't just
get added from the outset. Oh well, it probably won't hurt anything
significant.

If you want to use the version parameter in any other modules you'll
have to wait for the util-macros version bump, right?

Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>


More information about the xorg-devel mailing list