[PATCH x11proto] Add two more symbols for printing grab and window trees

Daniel Stone daniel at fooishbar.org
Fri Jun 17 08:51:56 PDT 2011


Hi,

On Thu, Jun 16, 2011 at 11:10:59AM +1000, Peter Hutterer wrote:
> These two keysyms provide exciting new possibilities of a close relationship
> between our valued users and hard-working developers through innovative
> logging solutions. Such keysyms truly pave new ground in the reponsiveness
> to bug reports and and debug-ability of grabs.
> 
> For unprecedented uses of these keysyms, see the patches here:
> http://patchwork.freedesktop.org/patch/5936/
> http://patchwork.freedesktop.org/patch/5935/
> 
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
> 
> man, if that doesn't sell it, I don't know what would.

Had we all sold X this well instead of trash-talking it at every turn,
Wayland might not exist today. ;)

> --- a/XF86keysym.h
> +++ b/XF86keysym.h
> @@ -229,4 +229,5 @@
>  #define XF86XK_ClearGrab	0x1008FE21   /* kill application with grab */
>  #define XF86XK_Next_VMode	0x1008FE22   /* next video mode available  */
>  #define XF86XK_Prev_VMode	0x1008FE23   /* prev. video mode available */
> -
> +#define XF86XK_PrintWindows     0x1008FE24   /* print window tree */
> +#define XF86XK_PrintGrabs       0x1008FE25   /* print all active grabs */

I'd prefer to have LogWindowTree and LogGrabInfo if possible.  Is this
OK with you?

If so, we should get an xproto out with these ASAP, and either way:
Reviewed-by: Daniel Stone <daniel at fooishbar.org>

Cheers,
Daniel


More information about the xorg-devel mailing list