[PATCH 1/2] DIX: Make PrintWindowTree actually useful

[Daniel Stone]

Hi,

On Wed, Jun 15, 2011 at 10:31:05PM -0700, Alan Coopersmith wrote:
> On 06/15/11 05:35 PM, Peter Hutterer wrote:
> > I don't seem to have a single window with a name. Can't spot the bug at a
> > glance though 
> > 
> > fwiw, xprop lists WM_NAME(STRING) = "xeyes" with WM_NAME being XA_WM_NAME
> 
> Shouldn't there be something after the continue statement in the block?
> Otherwise the if is pointless - if the if statement is true, go to the
> next iteration, else fall through to the next iteration.
> 
> Should it be reversed to:
> 	   if (prop->type == XA_STRING && prop->data &&
>                prop->propertyName == XA_WM_NAME)
> 		   return prop->data;
> 	}
> 	return NULL;
> }
> 
> or even just break instead of continue?

Comic.  I like your style, so I've used that.  Thanks!

Cheers,
Daniel