[PATCH xdm] Support installing systemd unit file.

Michał Górny mgorny at gentoo.org
Wed Jun 15 06:52:09 PDT 2011


On Wed, 15 Jun 2011 15:26:56 +0200 (CEST)
Mark Kettenis <mark.kettenis at xs4all.nl> wrote:

> > From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= <mgorny at gentoo.org>
> > Date: Wed, 15 Jun 2011 13:59:43 +0200
> > 
> > Signed-off-by: Michał Górny <mgorny at gentoo.org>
> > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=38339
> 
> >  Makefile.am     |   10 ++++++++++
> >  configure.ac    |   12 ++++++++++++
> >  xdm at .service.in |   10 ++++++++++
> 
> Is it really a good idea to have a file with an '@' character in its
> name?  It's not in the Portable Filename Character Set defined by
> POSIX.

Well, the other solution is to rename the file on generation/install.
In any case, systemd requires that character in order to support naming
the service 'xdm at ttyN.service' after install.

Considering the particular use cases, we don't need to worry about
portability of that particular character.

-- 
Best regards,
Michał Górny
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 316 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110615/cad97c7e/attachment-0001.pgp>


More information about the xorg-devel mailing list