[PATCH evdev 2/3] Print abs axes ranges on verbosity 6.

Peter Hutterer peter.hutterer at who-t.net
Tue Jun 14 18:02:46 PDT 2011


On Wed, Jun 15, 2011 at 01:59:24AM +0100, Daniel Stone wrote:
> On Wed, Jun 15, 2011 at 10:45:44AM +1000, Peter Hutterer wrote:
> > Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> > ---
> >  src/evdev.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/src/evdev.c b/src/evdev.c
> > index d261efd..8b01fb1 100644
> > --- a/src/evdev.c
> > +++ b/src/evdev.c
> > @@ -1531,6 +1531,8 @@ EvdevCache(InputInfoPtr pInfo)
> >                              i, strerror(errno));
> >                  goto error;
> >              }
> > +            xf86IDrvMsgVerb(pInfo, X_PROBED, 6, "absolute axis %#x [%d..%d]\n",
> > +                            i, pEvdev->absinfo[i].maximum, pEvdev->absinfo[i].minimum);
> >          }
> >      }
> 
> Hm, having this in decimal form is probably more useful since all the
> client utilities spit out decimal form only, but I can see the argument
> for synergy with kernel-side evdev.

note that this is the kernel axis number, not the XI axis number. The two
aren't related, if the kernel has axes 0x1, 0x5 and 0x7, evdev would
usually initialise with 3 axes numbered 0, 1, 2.

the hex output is much more useful here, it can be compared with linux/input.h

> Either way, for the series:
> Reviewed-by: Daniel Stone <daniel at fooishbar.org>

thanks

Cheers,
  Peter


More information about the xorg-devel mailing list