[PATCH 1/4] xserver: Use lists and constants for matching modes in Match entries

[Peter Hutterer]

On Wed, Jun 08, 2011 at 11:58:20PM +0300, Oleh Nykyforchyn wrote:
> On Wed, 8 Jun 2011 10:39:40 -0700
> Dan Nicholson <dbn.lists at gmail.com> wrote:
> 
> > On Sat, Jun 4, 2011 at 10:48 PM, Oleh Nykyforchyn <oleh.nyk at gmail.com> wrote:
> > > Use lists and constants for matching modes in Match entries
> > 
> > You're leaving out some critical information here. Particularly that
> > each Match entry would take multiple arguments.
> You are right, but it MAY take multiple arguments, and this possibility
> will not be used my most users. Most people simply will not notice
> anything and their "foo|bar" will work as before. For others "regex:^USB.*Mouse$"
> will be quite sufficient.
> 
> My reason to keep this option is the following: sometimes it is necessary
> to interleave positive and negated conditions (I have had such an experience
> in my multiseat setups, when input devices was to be distributed between seats).
> Any of these conditions can be regexes, and RE have no builtin negation, hence
> it is locical to accept multiple (negated and non-negated) RE's in a line. With a single
> argument, to glue RE's via '|', each '\' must be doubled, and all '|' in RE
> must be escaped, which is not very readable and convenient (imagine an explanation
> in man page). This option adds no computational overhead and does not make the code
> much more complicated. Why should we restrict ourselves to "many simple patterns or
> one regex"?
> 
> > I'm going to ignore
> > those details for now since I don't think we've agreed on it.
> But yes, commit messages will be expanded when we agree on details.

no, please expand them now. Commit messages are as much for reviewers as
they are for archeologists in a week's time. I can't point this one out
often enough:
http://who-t.blogspot.com/2009/12/on-commit-messages.html

Cheers,
  Peter