[PATCH:xkbcomp] Replace repeated checks for gcc with _X_ATTRIBUTE_PRINTF from xproto

Alan Coopersmith alan.coopersmith at oracle.com
Wed Jun 8 17:52:08 PDT 2011


On 06/ 8/11 01:06 AM, Mark Kettenis wrote:
>> From: Alan Coopersmith <alan.coopersmith at oracle.com>
>> Date: Tue,  7 Jun 2011 23:55:25 -0700
>>
>> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> 
> Strangely formatted code, but that's not your fault.

Yeah, xkbcomp's utils.h is rather messy all around - but as I looked
at cleaning it up I saw so many things that needed fixing, I just
punted for now.   It could use reformatting and dropping unused macros
(it defines 1-10 argument variants of each macro from the days before
 varargs macros, but many of those variants are never used).

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list