[PATCH 2/4] Remove the cacheing of the last scratch PixmapRec

Keith Packard keithp at keithp.com
Mon Jun 6 08:02:56 PDT 2011


On Mon, 06 Jun 2011 14:29:55 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:

> The critical notification that is missing is the one from
> FreeScratchPixmapHeader(). Adding a call to screen->ModifyPixmapHeader
> and listening for that in the ddx is sufficient for us to insert the
> appropriate barriers.

That's what I figured.

> I think using CreatePixmap(usage_hint=SCRATCH_HEADER) is a better
> solution, both from the perspective of the ddx and the core server. As
> there are no released drivers that depend upon that notification yet
> (otherwise this issue would have been raised earlier), let's fix it in
> a single step, at the beginning of the next cycle.

If we can offer an API compatible solution in 1.11, that would permit
drivers to be back-ported to 1.11, which would be nice. Not critical, of
course, just means that drivers would have to support both the 1.12 and
1.11 interfaces for a bit longer.

However, it sounds like these are two slightly different solutions to
the same problem, right?

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110606/e4d0d115/attachment.pgp>


More information about the xorg-devel mailing list