[PATCH 2/3] xkb: Fix case checks for Latin 2.
Cyril Brulebois
kibi at debian.org
Mon Jun 6 07:25:26 PDT 2011
Hello Daniel,
Daniel Stone <daniel at fooishbar.org> (06/06/2011):
> On Sun, Jun 05, 2011 at 03:27:08AM +0200, Cyril Brulebois wrote:
> > Those ones were getting _XkbKSLower for no reasons:
> > XK_ogonek: U+02DB OGONEK
> > XK_doubleacute: U+02DD DOUBLE ACUTE ACCENT
>
> I think this one also needs a check to exclude XK_breve.
keysymdef.h has:
| #define XK_Aogonek 0x01a1 /* U+0104 LATIN CAPITAL LETTER A WITH OGONEK */
| #define XK_breve 0x01a2 /* U+02D8 BREVE */
| #define XK_Lstroke 0x01a3 /* U+0141 LATIN CAPITAL LETTER L WITH STROKE */
xkbfmisc.c has:
| case 1: /* latin 2 */
| if (((ks>=XK_Aogonek)&&(ks<=XK_Zabovedot)&&(ks!=XK_breve))||
| ((ks>=XK_Racute)&&(ks<=XK_Tcedilla))) {
| rtrn|= _XkbKSUpper;
| }
So I think it's covered already?
> Otherwise, for all three patches:
> Reviewed-by: Daniel Stone <daniel at fooishbar.org>
Thanks for reviewing.
Mraw,
KiBi.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110606/d6bd3a5e/attachment.pgp>
More information about the xorg-devel
mailing list