[PATCH libXi 1/4] Add XI2 library-internal array offsets to XIint.h

Peter Hutterer peter.hutterer at who-t.net
Mon Jun 6 05:19:10 PDT 2011


On 6/06/11 21:56 , Daniel Stone wrote:
> On Thu, Jun 02, 2011 at 05:13:31PM +1000, Peter Hutterer wrote:
>> These defines are currently defined in XI.h and XI2.h. Their only use is as
>> offset into a library-internal array. Move them to XIint.h so they may be
>> removed from the protocol headers with the next revision.
>
> Hmm, I'm kind of uneasy about having new protocol headers break builds
> with old libraries. :\

I'm pretty sure we discussed this once before and the outcome was: the 
protocol headers can't be changed, the defines need to stay around.

what we can do however is _add_ them to libXi and ifdef them out 
accordingly. this also means that the ifndef will never be hit, but it's 
still easier to read this way.

so there is no matching patch for inputproto for this change, we keep 
the defines around for backwards compatibility. the new additions 
however are only in libXi.

Cheers,
   peter


More information about the xorg-devel mailing list